Update publish workflow for trusted publishers #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
2 tasks
|
We can then remove |
And the Looks like
|
|
Happy to remove that bot, thank you! |
|
Just removed it from PyPI. I think we need to keep as |
Why? |
|
Because it's still the bot creating the GitHub releases:
There is also still the need to the admin github token. But this might not be needed in a future version of the releaser: jupyter-server/jupyter_releaser#545 |
|
Ok 👍🏽 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Start using trusted publishers for publishing Voila to PyPI.
This will help to not have to deal with 2FA with the bot account: https://blog.pypi.org/posts/2024-01-01-2fa-enforced/
Code changes
publish-release.ymlto remove the PyPI token and set upid-tokenvoilaon PyPI to use trusted publishersUser-facing changes
None
Backwards-incompatible changes
None